Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made AsyncApiSchemaOptions inherit from JsonSchemaGeneratorSettings #206

Closed
wants to merge 1 commit into from

Conversation

Simkortet
Copy link

Recent change to NewtonsoftJsonSchemaGeneratorSettings does not allow compatibility with System.Text.Json and forces users of the saunter library to introduce newtonsoft into their projects.

@m-wild

Recent change to NewtonsoftJsonSchemaGeneratorSettings does not allow compatibility with System.Text.Json and forces users of the saunter library to introduce newtonsoft into their projects.
@Simkortet
Copy link
Author

@m-wild @VisualBean @yurvon-screamo

Any chance of closing this PR?

@VisualBean
Copy link
Collaborator

VisualBean commented May 8, 2024

@m-wild @VisualBean @yurvon-screamo

Any chance of closing this PR?

First off, it doesn't compile.
Also looking at the commentary from the PR that introduced the change in the first place, it looks like it needs a bigger redesign than simply changing the basetype here.

That and there seems to be quite a few whitespace changes here as well.

Even if it compiled, you'd still have the newtonsoft dependency stemming from the SerializerSettings (without looking at the rest of the changes that introduced this dependency)

@Simkortet Simkortet closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants