Skip to content

Conversation

zoghbi-a
Copy link
Contributor

@zoghbi-a zoghbi-a commented Sep 8, 2025

This PR adds several enhancements that have been added to include feedback from users (including reported issues; e.g #3387, #3321) since the last refactor to use the VO backend. The changes include:

  • Add query_by_column to allow querying of different catalog columns. The user passes a dict that is parsed into a TAP WHERE statements.
  • Add support for uploading tables when using TAP directly through query_tap.
  • Improve how maxrec works. If it is bigger than the default server limit, add a TOP statement.
  • Add automatic guessing for the data host in download_data

Because query_by_column shares code with the existing query_region, the shared part has now been moved to an internal function _query_execute, which is called by both query_by_column and query_region.

@zoghbi-a zoghbi-a marked this pull request as draft September 8, 2025 15:30
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 95.65217% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.64%. Comparing base (b918da4) to head (a3b86e8).
⚠️ Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/heasarc/core.py 95.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3403      +/-   ##
==========================================
+ Coverage   70.48%   70.64%   +0.16%     
==========================================
  Files         232      232              
  Lines       19977    20043      +66     
==========================================
+ Hits        14080    14159      +79     
+ Misses       5897     5884      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zoghbi-a zoghbi-a marked this pull request as ready for review September 8, 2025 16:18
@zoghbi-a zoghbi-a changed the title ENH: Add ability to query columns and upload tables Add ability to query columns and upload tables Sep 8, 2025
@bsipocz bsipocz added this to the 0.4.12 milestone Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants