JPLSpec: Download everything as a workaround for nonfunctional queroes #3396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ended for use when the online query tools are dead, but the data are still there
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
=======================================
Coverage ? 70.21%
=======================================
Files ? 232
Lines ? 20000
Branches ? 0
=======================================
Hits ? 14043
Misses ? 5957
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're still trying to fix the query tool:
#3363
But in the meantime, the data are all there, and they only amount to half a gigabyte total, so it's reasonable for a user to just download the whole thing locally. I may add some tools to interact with the locally-cloned database too.
Tests are needed.
@bsipocz I'm interested to hear your take on this sort of thing. There are a couple other databases that I'd like to add, like the NASA-hosted OCDB ice database and the Leiden LIDA, that have similar issues - i.e., it's a lot easier to download the whole thing rather than interact with their UI. I still think astroquery's the right place to put useful hacks like this, but let's talk about it.