Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typing imports for List, Tuple, Union #544

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

delucchi-cmu
Copy link
Contributor

See also: astronomy-commons/hats#441

A few kinds of typing imports remain, but the most annoying/silly ones have been removed.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (1c5c44f) to head (ef178be).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
- Coverage   97.34%   97.33%   -0.02%     
==========================================
  Files          43       43              
  Lines        1732     1724       -8     
==========================================
- Hits         1686     1678       -8     
  Misses         46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [1c5c44f] After [ac9c8bd] Ratio Benchmark (Parameter)
14.3±0.5ms 14.5±0.5ms 1.01 benchmarks.time_box_filter_on_partition
1.88±0.02s 1.88±0.03s 1 benchmarks.time_create_midsize_catalog
12.6±0.05s 12.5±0.1s 0.99 benchmarks.time_create_large_catalog
88.0±2ms 83.4±2ms 0.95 benchmarks.time_kdtree_crossmatch
29.5±2ms 28.0±0.3ms 0.95 benchmarks.time_polygon_search

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 6b1e683 into main Jan 24, 2025
11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/typing branch January 24, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants