-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address slow list operations in progress tracking. #468
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
=======================================
Coverage 94.55% 94.55%
=======================================
Files 28 28
Lines 1616 1617 +1
=======================================
+ Hits 1528 1529 +1
Misses 88 88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Most of my comments are quite optional, but I believe that compiling the regexes is worth doing if we know the data volume is large here.
Co-authored-by: Derek T. Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The current strategy of reading strings from file names, passing along those strings, and manually performing
not in
against constructed strings was taking foooorrrrreeeevvvveeeerrrrr in cases where there are 100k+ stages. This streamlines those operations, using integers and set operations where possible.