Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address slow list operations in progress tracking. #468

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Conversation

delucchi-cmu
Copy link
Contributor

The current strategy of reading strings from file names, passing along those strings, and manually performing not in against constructed strings was taking foooorrrrreeeevvvveeeerrrrr in cases where there are 100k+ stages. This streamlines those operations, using integers and set operations where possible.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (bacabec) to head (58f4630).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          28       28           
  Lines        1616     1617    +1     
=======================================
+ Hits         1528     1529    +1     
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Most of my comments are quite optional, but I believe that compiling the regexes is worth doing if we know the data volume is large here.

src/hats_import/catalog/resume_plan.py Show resolved Hide resolved
src/hats_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/margin_cache/margin_cache_resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/pipeline_resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/soap/resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/soap/resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/soap/resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
@gitosaurus gitosaurus self-requested a review January 8, 2025 15:33
Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delucchi-cmu delucchi-cmu merged commit c161725 into main Jan 8, 2025
8 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/slow branch January 8, 2025 15:56
@delucchi-cmu delucchi-cmu mentioned this pull request Jan 23, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants