Code review comments.

benchmarks/asv.conf.json

@@ -14,6 +14,9 @@
     "branches": [
         "HEAD"
     ],
+    "install_command": [
+        "python -mpip install -r requirements.txt {wheel_file}"
+    ],
     "build_command": [
         "python -m build --wheel -o {build_cache_dir} {build_dir}"
     ],

src/hipscat_cloudtests/file_checks.py

@@ -50,6 +50,9 @@ def assert_parquet_file_ids(
         file_name (str): fully-specified path of the file to read
         id_column (str): column in the parquet file to read IDs from
         expected_ids (:obj:`int[]`): list of expected ids in `id_column`
+        resort_ids (bool): should we re-sort the ids? if False, we will check that the ordering
+            is the same between the read IDs and expected_ids
+        storage_options (dict): dictionary of filesystem storage options
     """
     data_frame = pd.read_parquet(file_name, engine="pyarrow", storage_options=storage_options)
     assert id_column in data_frame.columns

src/hipscat_cloudtests/temp_cloud_directory.py

@@ -37,7 +37,7 @@ def __enter__(self):
             <prefix_path>/<method_name><some random string>
         """
         my_uuid = shortuuid.uuid()
-        self.temp_path = os.path.join(self.prefix_path, f"{self.method_name}{my_uuid}")
+        self.temp_path = os.path.join(self.prefix_path, f"{self.method_name}-{my_uuid}")
         return self.temp_path
 
     def __exit__(self, exc_type, exc_val, exc_tb):

tests/hipscat_import/conftest.py

@@ -20,7 +20,7 @@ def pytest_collection_modifyitems(items):
     """Modify dask unit tests to
         - ignore event loop deprecation warnings
         - have a longer timeout default timeout (5 seconds instead of 1 second)
-        - require use of the `dask_client` fixture, even if it's not requsted
+        - require use of the `dask_client` fixture, even if it's not requested
 
     Individual tests that will be particularly long-running can still override
     the default timeout, by using an annotation like: