Fix and more errors messages#353
Open
cooolgamer wants to merge 5 commits intoastronautlevel2:masterfrom
Open
Conversation
Contributor
Author
|
new changes are incoming, don't merge this yet |
Contributor
Author
|
As I said on the discord server, I tested it and it works fine so far. It may requires additional testing just in case |
Helloman892
reviewed
Jul 28, 2025
Helloman892
requested changes
Nov 10, 2025
Collaborator
Helloman892
left a comment
Helloman892
left a comment
There was a problem hiding this comment.
My general opinion hasn't changed; looks good, mostly minor details.
Helloman892
requested review from
LiquidFenrir and
astronautlevel2
and removed request for
LiquidFenrir
LiquidFenrir
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the compilation error by replacing the lang type from CONFIG to u8 type - tested and works fine2025-11-10: reverted because this got fixed in #358
Most importantly, this adds more error messages telling the user what to do instead of the generic error telling to contact a developer in the discord, who got bothered for nothing :)
This also fixes a compilation issue if the github app version is not found, setting the app to v0.0.0