Use stellar-core replay-in-memory catchup mode#23
Use stellar-core replay-in-memory catchup mode#23charlie-wasp wants to merge 18 commits intomasterfrom
Conversation
|
@nebolsin I revisited this PR, it seems to me that it's ready for review already. Here I used stellar-core |
c52c033 to
44695df
Compare
This reverts commit f8b9080.
f8a6fce to
78afe97
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| feeRows := make([]db.TxFeeHistoryRow, len(meta.V0.TxSet.Txs)) | ||
|
|
||
| for i, txe := range meta.V0.TxSet.Txs { | ||
| txHash, hashErr := util.HashTransactionInEnvelope(txe, networkPassphrase) |
There was a problem hiding this comment.
@charlie-wasp looks like you forgot to include util.HashTransactionInEnvelope:
go build -o dist/astrologer -v
github.com/astroband/astrologer/es
# github.com/astroband/astrologer/es
es/ledger_serializer.go:55:22: undefined: util.HashTransactionInEnvelope
There was a problem hiding this comment.
It's weird, I include util package here. I don't have any build errors on my dev machine, I'll try to investigate this
There was a problem hiding this comment.
@charlie-wasp yep, but there seems to be no HashTransactionInEnvelope method in github.com/astroband/astrologer/util package.
Addresses #20
This change is