Skip to content

Use stellar-core replay-in-memory catchup mode#23

Open
charlie-wasp wants to merge 18 commits intomasterfrom
play/stellar-core-replay
Open

Use stellar-core replay-in-memory catchup mode#23
charlie-wasp wants to merge 18 commits intomasterfrom
play/stellar-core-replay

Conversation

@charlie-wasp
Copy link
Copy Markdown
Collaborator

@charlie-wasp charlie-wasp commented Mar 27, 2020

Addresses #20

This change is Reviewable

@charlie-wasp charlie-wasp requested a review from nebolsin March 27, 2020 13:34
@charlie-wasp charlie-wasp marked this pull request as ready for review April 21, 2020 08:43
@charlie-wasp
Copy link
Copy Markdown
Collaborator Author

@nebolsin I revisited this PR, it seems to me that it's ready for review already. Here I used stellar-core replay-in-memory mode only in the export command. Not sure at the moment, can we adapt it for real-time ingesting at all 🤔

@charlie-wasp charlie-wasp force-pushed the play/stellar-core-replay branch from c52c033 to 44695df Compare July 15, 2020 12:22
@charlie-wasp charlie-wasp force-pushed the play/stellar-core-replay branch from f8a6fce to 78afe97 Compare August 14, 2020 08:01
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

feeRows := make([]db.TxFeeHistoryRow, len(meta.V0.TxSet.Txs))

for i, txe := range meta.V0.TxSet.Txs {
txHash, hashErr := util.HashTransactionInEnvelope(txe, networkPassphrase)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlie-wasp looks like you forgot to include util.HashTransactionInEnvelope:

 go build -o dist/astrologer -v
github.com/astroband/astrologer/es
# github.com/astroband/astrologer/es
es/ledger_serializer.go:55:22: undefined: util.HashTransactionInEnvelope

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird, I include util package here. I don't have any build errors on my dev machine, I'll try to investigate this

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlie-wasp yep, but there seems to be no HashTransactionInEnvelope method in github.com/astroband/astrologer/util package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants