fix segfault on conversion error #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I copy some text from a github commit inside Chrome, the selection cannot be converted to text. When I run `xclip -o` with that selection in the paste buffer, I get a segmentation fault because `free` is being called with an invalid argument (presumably because xcout isn't setting the `sel_buf` pointer correctly on error). ``` % xclip -o 1587474: signal: sys: segmentation violation (core dumped) ``` To fix this, remove the call to `free` in the error case, as it isn't really necessary anyway as the program is about to exit. When the `free` call is removed, `xclip` prints this error instead of seg-faulting: ``` xclip: Error: 'Chromium clipboard' (0x1c00024) cannot convert PRIMARY selection to target 'STRING' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I copy some text from a github commit inside Chrome,
the selection cannot be converted to text.
When I run
xclip -owith that selection in the paste buffer,I get a segmentation fault because
freeis being called withan invalid argument (presumably because xcout isn't setting the
sel_bufpointer correctly on error).To fix this, remove the call to
freein the error case, as it isn't really necessaryanyway as the program is about to exit.
When the
freecall is removed,xclipprints this error instead of seg-faulting: