Allow specifying script commands relative to the project root #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command paths with a leading `./` have the project root prepended, which allows scripts in the project tree to be used with `rye run` even when the current directory is not the project root.
brandon-avantus
force-pushed
the
relative-script-paths
branch
from
fd3a75f to
5bb584a
Compare
|
|
||
| let path = std::path::Path::new(&args[0]); | ||
| if path.starts_with("./") { | ||
| args[0] = pyproject.root_path().join(path).into(); |
There was a problem hiding this comment.
I think we should just always join this, since if path is absolute, joining just resolves to path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command paths with a leading
./have the project root prepended, which allows scripts in the project tree to be used withrye runeven when the current directory is not the project root.