Add autosync-before-run, --sync and --no-sync arguments to rye test and rye run (OneOffLock sync mode)
#1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
changed the title
autosync-before-run, --sync and --no-sync arguments to test (OneOff sync mode)autosync-before-run, --sync and --no-sync arguments to rye test and rye run (OneOff sync mode)
khvn26
force-pushed
the
feat/cli-test-autosync
branch
from
802171a to
a575b00
Compare
khvn26
changed the title
autosync-before-run, --sync and --no-sync arguments to rye test and rye run (OneOff sync mode)autosync-before-run, --sync and --no-sync arguments to rye test and rye run (OneOffLock sync mode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
--sync/--no-syncflag arguments torunandtestcommands. They control whether Rye should install project dependencies prior to executing either command.sync-before-runglobal configuration flag that controls the same thing.Note that this PR adds a special
OneOffLocksync mode that explicitly skips the locking step during sync if target lock file is present. I did this as I felt the implicit "no update" flag passed to locking backends inRegularmode wasn't a strong enough guarantee that the lock files won't be updated.Reject in favour of #1005 if you feel this is an overkill.
Closes #886.