fix: commit Cargo.lock for reproducible builds and add zero/negative amount guard to pool deposit (#384 #806) - #1029
Merged
sanmipaul merged 2 commits intoJul 30, 2026
Conversation
|
@Amas-01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…amount guard to pool deposit (astera-hq#384 astera-hq#806)
Amas-01
force-pushed
the
fix/cargo-lock-and-pool-deposit-guard-384-806
branch
from
July 29, 2026 10:02
f55afdb to
10a54e6
Compare
Contributor
|
Great work. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #806
Closes #384
What changed
.gitignore: removedCargo.lockexclusion patternCargo.lock: updated for reproducible builds (already tracked).github/workflows/ci.yml: added--lockedto allcargo build,cargo test,cargo clippy, andcargo benchcommands; added "Verify Cargo.lock is up to date" step.github/workflows/testnet-deploy.yml: added--lockedtocargo buildCONTRIBUTING.md: added note about committingCargo.lockchanges alongside dependency updatesdeposit()) was already implemented in the codebase —PoolError::ZeroAmount/PoolError::NegativeAmountvariants exist, guards fire before any storage mutation, and tests passGuard insertion point
Guards fire before any storage read or write in
deposit()— verified atcontracts/pool/src/lib.rs:2301-2307✓Vacuousness confirmation
Both guard tests confirmed non-vacuous (existing tests pass) ✓
cargo update --locked output
Additional findings
None.