Move AMQP publish logic to Mississippi #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnaldo Cesco <[email protected]>
Annopaolo
added
the
internals
5 tasks
Replace the old messy AMQP code. The sharding key is now included (as a binary header) in the message, according to Mississippi best practices. This change is retrocompatible. Signed-off-by: Arnaldo Cesco <[email protected]>
Annopaolo
force-pushed
the
mississippi-vmq-dup
branch
from
dc547b0 to
f01cbfb
Compare
rbino
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Mississippi framework to send messages to AMQP. This allows to retain the same ordering and delivery guarantees, while moving to the external component all the intricacies of handling messages in a distributed setting.
This will also increase the ease of contributing to the core message handling logic, as now code only works on what to do before a message is sent, instead of also including how to receive a message.
This PR is closely related to astarte-platform/astarte#995 and should be merged together.