-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature): MacOS porting #1019
base: master
Are you sure you want to change the base?
(feature): MacOS porting #1019
Conversation
50b76bb
to
1cd15e6
Compare
ab896c7
to
3473f4f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1019 +/- ##
==========================================
- Coverage 69.36% 66.02% -3.35%
==========================================
Files 275 65 -210
Lines 7152 3376 -3776
==========================================
- Hits 4961 2229 -2732
+ Misses 2191 1147 -1044 ☔ View full report in Codecov by Sentry. |
f0b9445
to
35624c9
Compare
3773f10
to
24f242f
Compare
24f242f
to
722cabc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is good, thank you! I only left some comments that can be applied to all services
6c21206
to
271412b
Compare
- upgraded base image (old image only builds on amd64, not Apple Silicon) - bump scylladb image 6.2v - added .DS_Store to gitignore Scylladb old container version raises an error on macos: ``` 15:06:49.420 [error] GenServer :xandra terminating 2024-11-22 16:06:49 ** (CaseClauseError) no case clause matching: {:error, {{{:badmatch, {:error, {:bad_return, {DBConnection.ConnectionPool.Pool, :init, {:child_spec, 1}}}}}, [{DBConnection.ConnectionPool, :init, 1, [file: ~c"lib/db_connection/connection_pool.ex", line: 48]}, {:gen_server, :init_it, 2, [file: ~c"gen_server.erl", line: 962]}, {:gen_server, :init_it, 6, [file: ~c"gen_server.erl", line: 917]}, {:proc_lib, :init_p_do_apply, 3, [file: ~c"proc_lib.erl", line: 241]}]}, {:child, :undefined, {{172, 20, 0, 5}, 9042}, {Xandra, :start_link, [[authentication: {Xandra.Authenticator.Password, [username: "cassandra", password: "cassandra"]}, pool_size: 10, encryption: false, nodes: ["172.20.0.5:9042"], registry: :"Elixir.Xandra.ClusterRegistry.9", connection_listeners: [#PID<0.1354.0>]]]}, :transient, false, 5000, :worker ```` Signed-off-by: Gabriele Ghio <[email protected]>
Signed-off-by: Gabriele Ghio <[email protected]>
271412b
to
b77ac19
Compare
d80d6fa
to
67dfadd
Compare
* astarte_housekeeping * astarte_housekeeping_api * astarte_data_updater_plant * astarte_pairing * astarte_pairing_api * astarte_realm_management * astarte_realm_management_api * astarte_trigger_engine * astarte_appengine_api Signed-off-by: Gabriele Ghio <[email protected]>
67dfadd
to
8a083f9
Compare
Enhance MacOS Compatibility and Development Setup
Key Changes
Updated Vernemq Start Script:
Built Astarte Applications and Devcontainer:
astarte_housekeeping
astarte_housekeeping_api
astarte_data_updater_plant
astarte_pairing
astarte_pairing_api
astarte_realm_management
astarte_realm_management_api
astarte_trigger_engine
astarte_appengine_api
Docker Build Enhancements:
docker-compose.dev
for a clearer and more modular structure.ScyllaDB Image Update:
.DS_Store
to.gitignore
to prevent unnecessary files from being tracked.Motivation
Testing