New license manager #1010

eddbbt · 2024-10-29T10:57:42Z

This PR adopts Reuse for managing files license
Files copyright years have been changed based on git commit metadata

codecov · 2024-10-29T11:05:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.48%. Comparing base (c5e192c) to head (8635f06).
Report is 17 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
+ Coverage   69.35%   70.48%   +1.12%     
==========================================
  Files         275      166     -109     
  Lines        7149     4692    -2457     
==========================================
- Hits         4958     3307    -1651     
+ Misses       2191     1385     -806

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Annopaolo · 2024-12-02T13:24:53Z

.github/workflows/reuse.yaml

+    steps:
+      - uses: actions/checkout@v4
+      - name: REUSE Compliance Check
+        uses: fsfe/reuse-action@v4


Nit: there's a newline more

Annopaolo · 2024-12-02T13:25:52Z

CONTRIBUTING.md


-  SPDX-License-Identifier: CC0-1.0
+SPDX-License-Identifier: Apache-2.0


Let's not change license here:

Suggested change

SPDX-License-Identifier: Apache-2.0

SPDX-License-Identifier: CC0-1.0

Annopaolo · 2024-12-02T13:43:07Z

LICENSE

Let's also keep the LICENSE file

Annopaolo · 2024-12-02T13:44:12Z

apps/astarte_appengine_api/config/releases.exs

+# Copyright 2017-2020 SECO Mind Srl
 #
-# This file is part of Astarte.
-#
-# Copyright 2020 Ispirata Srl
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
+# SPDX-License-Identifier: Apache-2.0


Please do not remove old license headers, just update them

reuse annotate all astarte files with a copyright years extracted from first and last commit per file Signed-off-by: Eddy Babetto <[email protected]>

Updated the header comments in the files to conform to the reuse policy guidelines. Signed-off-by: Alem Puskarevic <[email protected]> Signed-off-by: Eddy Babetto <[email protected]>

Annopaolo · 2024-12-04T11:44:28Z

tools/astarte_e2e/priv/interfaces/org.astarte-platform.e2etest.SimpleDatastream.json.license

The *.json.license files in this directory break the CI (see this run) because astartectl tries to install all files in the directory as interfaces.
Either edit the workflow or (my personal preference) add a REUSE.toml file in the priv parent directory with the licensing information. You can check in the Reuse FAQ and specification for the specific syntax

Also, in order to be consistent with standard-interfaces, I'd suggest to use the CC-1.0 license for interfaces here too

Annopaolo · 2024-12-04T11:48:09Z

...vice_fleet_simulator/priv/interfaces/org.astarte-platform.genericsensors.Values.json.license

In order to be consistent with standard-interfaces, I'd suggest using CC-1.0 here too

Annopaolo · 2024-12-06T15:09:33Z

.github/workflows/reuse-workflow.yaml

+      - uses: actions/checkout@v4
+      - name: REUSE Compliance Check
+        uses: fsfe/reuse-action@v4
+


Nit: files should end with just a newline

Annopaolo · 2024-12-09T10:53:56Z

.github/workflows/reuse-workflow.yaml

+      - uses: actions/checkout@v4
+      - name: REUSE Compliance Check
+        uses: fsfe/reuse-action@v4
+


There's still a newline error here, please fix it

Also, this workflow is not related to the Tidy up old copyright info commit it's in

Remove old copyright info Check copyright year based on git file info, not on old copy-paste values Signed-off-by: Eddy Babetto <[email protected]>

Create a Reuse worflow for check files copyright compliance Signed-off-by: Eddy Babetto <[email protected]>

eddbbt · 2024-12-18T17:01:54Z

clea_bw.png added as apache 2.0

eddbbt force-pushed the new-licence branch 3 times, most recently from 8a2ece1 to 1dfbb20 Compare October 29, 2024 11:49

eddbbt changed the title ~~New licence~~ New licence manager Oct 29, 2024

alempuskarevic force-pushed the new-licence branch 2 times, most recently from 23a82f6 to 2bd95bd Compare December 2, 2024 10:11

Annopaolo requested changes Dec 2, 2024

View reviewed changes

eddbbt force-pushed the new-licence branch 2 times, most recently from 2c253bb to b956d3c Compare December 3, 2024 13:31

eddbbt and others added 2 commits December 3, 2024 17:17

Run reuse annotate with correct files dates

cb70334

reuse annotate all astarte files with a copyright years extracted from first and last commit per file Signed-off-by: Eddy Babetto <[email protected]>

Update file headers to comply with reuse policy

43eb038

Updated the header comments in the files to conform to the reuse policy guidelines. Signed-off-by: Alem Puskarevic <[email protected]> Signed-off-by: Eddy Babetto <[email protected]>

eddbbt force-pushed the new-licence branch from b956d3c to 7e8fb63 Compare December 3, 2024 16:22

eddbbt changed the title ~~New licence manager~~ New license manager Dec 3, 2024

Annopaolo requested changes Dec 4, 2024

View reviewed changes

eddbbt force-pushed the new-licence branch 6 times, most recently from 0591dfb to 8795869 Compare December 6, 2024 14:36

Annopaolo reviewed Dec 6, 2024

View reviewed changes

eddbbt force-pushed the new-licence branch from 8795869 to c402aae Compare December 6, 2024 15:41

Annopaolo requested changes Dec 9, 2024

View reviewed changes

eddbbt force-pushed the new-licence branch 2 times, most recently from 84de061 to 8635f06 Compare December 16, 2024 17:24

eddbbt added 2 commits December 18, 2024 18:01

Tidy up old copyright info

cbd6032

Remove old copyright info Check copyright year based on git file info, not on old copy-paste values Signed-off-by: Eddy Babetto <[email protected]>

Create Reuse workflow

a3c281d

Create a Reuse worflow for check files copyright compliance Signed-off-by: Eddy Babetto <[email protected]>

eddbbt force-pushed the new-licence branch from 8635f06 to a3c281d Compare December 18, 2024 17:01

eddbbt marked this pull request as ready for review December 18, 2024 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New license manager #1010

New license manager #1010

eddbbt commented Oct 29, 2024 •

edited

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading

Annopaolo Dec 2, 2024

Annopaolo Dec 2, 2024

Annopaolo Dec 2, 2024

Annopaolo Dec 2, 2024

Annopaolo Dec 4, 2024

Annopaolo Dec 4, 2024

Annopaolo Dec 4, 2024 •

edited

Loading

Annopaolo Dec 6, 2024

Annopaolo Dec 9, 2024

Annopaolo Dec 9, 2024

eddbbt commented Dec 18, 2024


		SPDX-License-Identifier: CC0-1.0
		SPDX-License-Identifier: Apache-2.0

New license manager #1010

Are you sure you want to change the base?

New license manager #1010

Conversation

eddbbt commented Oct 29, 2024 • edited Loading

codecov bot commented Oct 29, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Annopaolo Dec 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eddbbt commented Dec 18, 2024

eddbbt commented Oct 29, 2024 •

edited

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading

Annopaolo Dec 4, 2024 •

edited

Loading