Skip to content

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Feb 7, 2024

Ellipsis 🚀 This PR description was created by Ellipsis for commit 1f11b4f.

Summary:

This PR moves the tests folder to the top level of the project structure and updates various files to reflect this change, including workflow files, test setup scripts, and test files.

Key points:

  • Moved tests folder to top level.
  • Updated .github/workflows/ci.yml and .github/workflows/publish.yml to use .nvmrc for Node.js version.
  • Updated scripts/test/testSetup.ts to import activate from new utils location.
  • Updated src/extension.ts to use path.join for configUri.
  • Moved and updated test files in src/test to tests.
  • Moved and updated src/test/utils.ts to tests/utils.ts.

Generated with ❤️ by ellipsis.dev

@SoonIter SoonIter force-pushed the soon/chore/infra branch 2 times, most recently from 2103237 to 4a1d7f2 Compare February 7, 2024 10:39
@HerringtonDarkholme
Copy link
Member

any merit to move test to top level?

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!


Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.

Generated with ❤️ by ellipsis.dev

@SoonIter
Copy link
Member Author

SoonIter commented Feb 8, 2024

any merit to move test to top level?

:-) There are no obvious benefits but I think we will move the tests directory to the top layer sooner or later, because we use tsx to run ts code instead of compiling it. By the way, I'm testing the failing reason for window CI in this pr , it seems that Macos is also unstable ...

@SoonIter SoonIter marked this pull request as draft February 8, 2024 07:55
@HerringtonDarkholme HerringtonDarkholme marked this pull request as ready for review February 18, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants