Use packaged wpcs #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest currently available version of WordPress-Coding-Standards is 2.3.0, released in May 2020.
That version is not compatible with PHP 8.0. The compatibility was fixed in WordPress/WordPress-Coding-Standards@7cd46be just few months later.
As of January 2023, there is no version of PHP 7.x maintained upstream.
I am not interested in developing against unsupported version of PHP. On the other hand, there is no packaged version of WPCS I could use in PHP 8 environment.
As a temporary solution, I switched WPCS to git version. But we should switch back to packaged version as soon as there is PHP 8-compatible package available.
This PR contains changes that are assumed to be sufficient for the switch. But we will need to verify once WPCS releases new version.