use clay %cult endpoint for more reliable sub count data#4
Open
sidnym-ladrut wants to merge 5 commits into
Open
use clay %cult endpoint for more reliable sub count data#4sidnym-ladrut wants to merge 5 commits into
%cult endpoint for more reliable sub count data#4sidnym-ladrut wants to merge 5 commits into
Conversation
add complete instructions for 'install dependencies' step
sidnym-ladrut
commented
Apr 30, 2024
| git clone -b 411k --depth 1 https://github.com/urbit/urbit.git urb | ||
| cp urb/pkg/arvo/lib/{agentio*,verb*,strand*} vita-full/lib/ | ||
| cp urb/pkg/arvo/sur/{spider*,verb*} vita-full/sur/ | ||
| git clone -b sl/server-schooner-z412k --depth 1 https://github.com/sidnym-ladrut/yard.git yar |
Author
There was a problem hiding this comment.
Quick note here: I need to follow up with @sigilante to get the 412k schooner fix into %yard proper and then this code can just pull from the master branch. Alternatively, I can just omit these more explicit install instructions.
sidnym-ladrut
force-pushed
the
sl/improve-install-data-reliability
branch
from
c87900b to
fb5881d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
%vitauses the/c/s/[our]/[desk]/[now]/subsendpoint in order to determine the number of ships that have downloaded the desk[desk]distributed by the host ship[our]. Mechanically, this is implemented by tallying the number of outstanding%claysubscriptions for various paths within this desk. Unfortunately, not all of these subscriptions represent full desk installs (e.g.%hitssubscribes to just the docket file in a desk), causing this statistic to be greatly inflated.This PR changes
%vitato pull subscriptions from the/c/x/[our]//[now]/cult/[desk]endpoint, filtered by full desk subscriptions to the latest version of the desk. This data more accurately captures the current number of live subscribers. This PR also includes a couple of smaller changes, i.e. (1) renaming+share-usageto+toggle-vitaand (2) removing the client-side "already sent data" debugging log statement.