Tweaks to align with latest TechEmpower platform benchmark code #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianEdwards
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
It seems there's some other changes from the TechEmpower implementation that haven't been ported back here yet. Can we add those too?
https://github.com/TechEmpower/FrameworkBenchmarks/pull/8005/files#diff-f78bda6358aecc5f94ced32649254c08f61b5e8ecb39b421c1824abff193ccbeR19-R32
There was a problem hiding this comment.
Just need to merge the PR 😉
|
Seems no rebase is needed after @benaadams' PR got merged so I'll go ahead and merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See TechEmpower/FrameworkBenchmarks#8005
/cc @DamianEdwards @sebastienros