Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use shared args for swcrc, source_root params #271

Merged
merged 1 commit into from
Sep 9, 2024
Merged

perf: use shared args for swcrc, source_root params #271

merged 1 commit into from
Sep 9, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Aug 28, 2024

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested a review from gregmagolan August 28, 2024 23:53
@jbedard jbedard changed the title perf: use shared args for source_root param perf: use shared args for swcrc, source_root params Aug 29, 2024
@jbedard jbedard requested review from alexeagle and thesayyn August 29, 2024 00:39
@jbedard jbedard merged commit 9498a51 into main Sep 9, 2024
11 checks passed
@jbedard jbedard deleted the args-base branch September 9, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @thesayyn