Skip to content

Conversation

tyler-french
Copy link

In order to use the --repo_contents_cache, we need to mark the repository rule as reproducible.

See bazel-contrib/bazel-gazelle#2119 as an example

Changes are visible to end-users: yes/no

The contents of their repo_contents_cache might be different.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

aspect-workflows bot commented Sep 25, 2025

Test

All tests were cache hits

222 tests (100.0%) were fully cached saving 28s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 621ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 200ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 5s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 605ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 479ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 387ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 114ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 496ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

67 tests (100.0%) were fully cached saving 10s.


Test

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 4s.


Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 466ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 246ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 111ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 118ms.


Buildifier      Format

@jbedard
Copy link
Member

jbedard commented Sep 27, 2025

@tyler-french have time to fix the lint errors? Maybe switch to:

if not hasattr(rctx, "repo_metadata"):
    return None
return rctx.repo_metadata(reproducible = reproducible)

which will allow simply deleting 2 lines if/when we remove older bazel versions that need the if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants