Skip to content

Conversation

guw
Copy link

@guw guw commented Aug 24, 2025

js_binary should use the new runtime toolchain to avoid execution toolchain being leaked into target environments (eg., js_image_oci)

See bazel-contrib/rules_nodejs#3854

Depends on:

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Switched js_binary (and js_test) to start using the new runtime toolchain type introduced by rules_nodejs to better support cross-platform builds (eg., building arm64 container from amd64).

Test plan

  • Covered by existing test cases

js_binary should use the new runtime toolchain to avoid execution toolchain being leaked into target environments (eg.,  js_image_oci)

See bazel-contrib/rules_nodejs#3854
Copy link

aspect-workflows bot commented Aug 24, 2025

Test

⚠️ Buildkite build #9180 failed.


Test

e2e/bzlmod

⚠️ Buildkite build #9180 failed.


Test

e2e/gyp_no_install_script

⚠️ Buildkite build #9180 failed.


Test

e2e/js_image_oci

⚠️ Buildkite build #9180 failed.


Test

e2e/npm_link_package

⚠️ Buildkite build #9180 failed.


Test

e2e/npm_link_package-esm

⚠️ Buildkite build #9180 failed.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 29ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 29ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 86ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 20ms.


Test

e2e/npm_translate_lock_replace_packages

⚠️ Buildkite build #9180 failed.


Test

e2e/npm_translate_lock_subdir_patch

⚠️ Buildkite build #9180 failed.


Test

e2e/npm_translate_package_lock

⚠️ Buildkite build #9180 failed.


Test

e2e/npm_translate_yarn_lock

⚠️ Buildkite build #9180 failed.


Test

e2e/package_json_module

⚠️ Buildkite build #9180 failed.


Test

e2e/pnpm_lockfiles

⚠️ Buildkite build #9180 failed.


Test

e2e/pnpm_workspace

⚠️ Buildkite build #9180 failed.


Test

e2e/pnpm_workspace_rerooted

⚠️ Buildkite build #9180 failed.


Test

e2e/repo_mapping

⚠️ Buildkite build #9180 failed.


Test

e2e/rules_foo

⚠️ Buildkite build #9180 failed.


Test

e2e/runfiles

⚠️ Buildkite build #9180 failed.


Test

e2e/vendored_node

⚠️ Buildkite build #9180 failed.


Buildifier      Format

@keith
Copy link
Contributor

keith commented Aug 26, 2025

nice, verified this fixes this case too #2328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants