Windows test fixes & enable tests in CI

[peakschris]

Changes:

• Fix js_binary to run on windows without bash; works both in js_image_layer and via bazel
• Disable failing tests due to windows or --noenable_runfiles
• Enable windows CI
• Bump aspect_bazel_lib and tar.bzl to fix windows tar toolchain issues

[aspect-workflows]

Test

⚠️ Buildkite build #9387 failed.

//js/private/test/image:tar_listing failed to build

failed to create symbolic link 'bazel-out/k8-fastbuild/bin/js/private/test/image/tar_listing': file 'js/private/test/image/tar_listing.sh' is not executable

failed to create symbolic link 'bazel-out/k8-opt-exec-ST-d57f47055a04/bin/js/private/test/image/tar_listing': file 'js/private/test/image/tar_listing.sh' is not executable

Failed tests (2)

//js/private/test/image:checksum_test_test_test [k8-fastbuild]                🔗
//js/private/test:write_launcher_test [k8-fastbuild]                          🔗

💡 To reproduce the build failures, run

bazel build //js/private/test/image:tar_listing //js/private/test/image:tar_listing

💡 To reproduce the test failures, run

bazel test //js/private/test:write_launcher_test //js/private/test/image:checksum_test_test_test

---

Test

e2e/bzlmod

2 test targets passed

Targets

//:jasmine_test [k8-fastbuild]                                                                         259ms
//:test [k8-fastbuild]                                                                                 177ms

Total test execution time was 436ms. 3 tests (60.0%) were fully cached saving 107ms.

---

Test

e2e/gyp_no_install_script

1 test target passed

Targets

//:test [k8-fastbuild]                                                                                 103ms

Total test execution time was 103ms. 1 test (50.0%) was fully cached saving 103ms.

---

Test

e2e/js_image_oci

⚠️ Buildkite build #9387 failed.

Failed tests (1)

//src:image_test [k8-fastbuild]                                               🔗

💡 To reproduce the test failures, run

bazel test //src:image_test

---

Test

e2e/npm_link_package

2 test targets passed

Targets

//:aspect_test_a_bin_test [k8-fastbuild]                                                               241ms
//src:test [k8-fastbuild]                                                                              151ms

Total test execution time was 392ms. 1 test (33.3%) was fully cached saving 54ms.

---

Test

e2e/npm_link_package-esm

2 test targets passed

Targets

//:aspect_test_a_bin_test [k8-fastbuild]                                                               208ms
//src:test [k8-fastbuild]                                                                              140ms

Total test execution time was 348ms. 1 test (33.3%) was fully cached saving 54ms.

---

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

---

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

---

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.

---

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.

---

Test

e2e/npm_translate_lock_replace_packages

1 test target passed

Targets

//:test [k8-fastbuild]                                                                                 94ms

Total test execution time was 94ms. 2 tests (66.7%) were fully cached saving 286ms.

---

Test

e2e/npm_translate_lock_subdir_patch

1 test target passed

Targets

//subdir:test                                                                                          115ms

---

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

---

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

---

Test

e2e/package_json_module

1 test target passed

Targets

//:test                                                                                                298ms

---

Test

e2e/pnpm_lockfiles

11 test targets passed

Targets

//cases/versionless-patch-v9:versionless_patch_test [k8-fastbuild]                                     173ms
//v101:aliases-test [k8-fastbuild]                                                                     210ms
//v101:patch-test [k8-fastbuild]                                                                       176ms
//v54:aliases-test [k8-fastbuild]                                                                      401ms
//v54:patch-test [k8-fastbuild]                                                                        115ms
//v60:aliases-test [k8-fastbuild]                                                                      310ms
//v60:patch-test [k8-fastbuild]                                                                        171ms
//v61:aliases-test [k8-fastbuild]                                                                      224ms
//v61:patch-test [k8-fastbuild]                                                                        334ms
//v90:aliases-test [k8-fastbuild]                                                                      570ms
//v90:patch-test [k8-fastbuild]                                                                        125ms

Total test execution time was 3s. 56 tests (83.6%) were fully cached saving 6s.

---

Test

e2e/pnpm_workspace

6 test targets passed

Targets

//app/a:aspect_test_a_bin_test [k8-fastbuild]                                                          346ms
//app/a:test [k8-fastbuild]                                                                            349ms
//app/b:test [k8-fastbuild]                                                                            429ms
//app/c:aspect_test_a_bin_test [k8-fastbuild]                                                          357ms
//app/c:test [k8-fastbuild]                                                                            601ms
//app/d:test [k8-fastbuild]                                                                            528ms

Total test execution time was 3s. 9 tests (60.0%) were fully cached saving 1s.

---

Test

e2e/pnpm_workspace_rerooted

6 test targets passed

Targets

//app/a:aspect_test_a_bin_test [k8-fastbuild]                                                          359ms
//app/a:test [k8-fastbuild]                                                                            313ms
//app/b:test [k8-fastbuild]                                                                            244ms
//app/c:aspect_test_a_bin_test [k8-fastbuild]                                                          424ms
//app/c:test [k8-fastbuild]                                                                            449ms
//app/d:test [k8-fastbuild]                                                                            407ms

Total test execution time was 2s. 9 tests (60.0%) were fully cached saving 2s.

---

Test

e2e/repo_mapping

1 test target passed

Targets

//:test [k8-fastbuild]                                                                                 191ms

Total test execution time was 191ms. 2 tests (66.7%) were fully cached saving 310ms.

---

Test

e2e/rules_foo

1 test target passed

Targets

//foo:test [k8-fastbuild]                                                                              211ms

Total test execution time was 211ms. 1 test (50.0%) was fully cached saving 48ms.

---

Test

e2e/runfiles

1 test target passed

Targets

//:runfiles [k8-fastbuild]                                                                             76ms

---

Test

e2e/vendored_node

1 test target passed

Targets

//:test [k8-fastbuild]                                                                                 169ms

---

Buildifier      Format

[peakschris]

@alexeagle could you take a look at / rerun the one failing job? Looks like an environment issue