Skip to content

devserver: skip unlink when possible #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

devserver: skip unlink when possible #2115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eaacfeb
devserver: skip unlink when possible
dmiller-figma Mar 3, 2025
0337bcb
devserver: skip unlink when possible
dmiller-figma Mar 3, 2025
4beb66d
Add `grant_sandbox_write_permissions = True` to all devserver targets
dmiller-figma Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions e2e/js_run_devserver/src/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ js_run_devserver(
":web_files",
],
log_level = "debug",
grant_sandbox_write_permissions = True,
)

# Now the js_binary variant
Expand All @@ -141,6 +142,7 @@ js_run_devserver(
],
log_level = "debug",
tool = ":simple_bin",
grant_sandbox_write_permissions = True,
)

# Intentionally a js_library and not a js_binary to test that transitive npm are
Expand Down
9 changes: 3 additions & 6 deletions js/private/js_run_devserver.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,14 +214,11 @@ async function syncRecursive(src, dst, sandbox, writePerm) {

if (process.env.JS_BINARY__LOG_DEBUG) {
console.error(
`Syncing file ${src.slice(
RUNFILES_ROOT.length + 1
)} (${friendlyFileSize(lstat.size)})`
`Syncing file ${src} (${friendlyFileSize(lstat.size)}) to ${dst}`
)
console.error(`Dst exists: ${exists}`)
}
if (exists) {
await fs.promises.unlink(dst)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to keep this when !grant_sandbox_write_permissions?

} else {
if (!exists) {
// Intentionally synchronous; see comment on mkdirpSync
mkdirpSync(path.dirname(dst))
}
Expand Down
Loading