feat: generate angular-ngc sass_binary targets with aspect configure plugin #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alexeagle
approved these changes
Mar 5, 2025
.bazeliskrc
Outdated
| @@ -1,5 +1,5 @@ | |||
| BAZELISK_BASE_URL=https://static.aspect.build/aspect | |||
| USE_BAZEL_VERSION=aspect/2024.51.11 | |||
| BAZELISK_BASE_URL=https://s3.us-east-2.amazonaws.com/aspect-static-dev/aspect | |||
There was a problem hiding this comment.
do we really want to change from prod to a dev pre-release?
There was a problem hiding this comment.
We should probably just tag a new prod release...
There was a problem hiding this comment.
SGTM if the most recent prod release is missing changes that are required for this to work :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the aspect-cli to the latest pro version. Generate the angular-ngc
sass_binarytargets automatically.Changes are visible to end-users: yes
Add example aspect orion plugin for BUILD generation.
Test plan