Skip to content
This repository was archived by the owner on Apr 14, 2025. It is now read-only.

Conversation

@dzbarsky
Copy link

This depends on a change to the esbuild rules that exposes the transpiler

@gregmagolan
Copy link
Member

Nice. Thanks for the PR. Can you rebase? The rules_ts benchmark now runs on CI so it will exercise the new code.

@dzbarsky
Copy link
Author

Sure, but it depends on aspect-build/rules_esbuild#62. Would you recommend pointing the rules_esbuild workspace in this PR at that branch?

@gregmagolan
Copy link
Member

Sure, but it depends on aspect-build/rules_esbuild#62. Would you recommend pointing the rules_esbuild workspace in this PR at that branch?

Sure. That will work. Its pointing to an unlanded branch of rules_swc as well.

@jbedred or I will review #62 when we have some time.

@dzbarsky
Copy link
Author

OK, done. I think you need to approve the workflow since I'm a first-time contributor so we can make sure CI is happy

@gregmagolan
Copy link
Member

Looks like CI is broken for PRs from forks because of EngFlow RBE configuration. I'll test this locally instead. You'll have rebase some more as I landed some changes created merge conflicts.

@cgrindel
Copy link

@dzbarsky Just wanted to check-in to see if you would like to get this PR merged. If so, could you do a rebase and let us know?

@dzbarsky
Copy link
Author

It was just a proof-of-concept, I'm ok abandoning it.

@dzbarsky dzbarsky closed this Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants