Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate long filename in header #58

Closed
wants to merge 1 commit into from
Closed

Truncate long filename in header #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions babi/screen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,19 @@ def _draw_header(self) -> None:
filename += ' *'
if len(self.files) > 1:
files = f'[{self.i + 1}/{len(self.files)}] '
version_width = len(VERSION_STR) + 2 + len(files)
else:
files = ''
version_width = len(VERSION_STR) + 2
centered = filename.center(self.margin.cols)[version_width:]
s = f' {VERSION_STR} {files}{centered}{files}'

before, after = f' {VERSION_STR} {files}', f'{files}'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the second fstring here does nothing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about this:
As far as I understand this, the right hand side files indicator would always be offscreen.
Firstly, am I correct in my understanding of this?
Second, is this intentional, should it be shown, or should it just go away?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's a mistake on my part 😆 -- it should just go away. that's what you get for writing code while streaming 😆

room_for_filename = self.margin.cols - 2 * len(before)
if len(filename) > room_for_filename:
truncate = '... '
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest of the project utilizes the ellipsis character -- this also makes truncation preserve more characters

if len(truncate) >= room_for_filename:
truncate = ''
filename = truncate + filename[-room_for_filename + len(truncate):]

centered = filename.center(self.margin.cols)
s = before + centered[len(before) - 1:-len(after) - 1] + after
self.stdscr.insstr(0, 0, s, curses.A_REVERSE)

def _get_sequence_home_end(self, wch: str) -> str:
Expand Down