Fix a bug in the 'redirect' mechanism. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se a PermError to be returned instead of executing the test.
|
Hey, I was working on a personal feature to be able to generate an allow list of networks from an SPF record for later use rather than execute a check 'here and now' against a single ip and noticed the redirect spf test would not be executed. Let me know if you'd be interested in that code when it's done - it cannot support PTR mechanisms as that requires an IP at run time which might be an issue but they're depricated anyway and I know I won't need them so I'm good anyway! 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A non nil error would cause a PermError to be returned instead of executing the test.