Skip to content

feat: Add --ref flag for asdf plugin add #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add --ref flag for asdf plugin add #2153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions internal/cli/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,12 @@ func Execute(version string) {
Commands: []*cli.Command{
{
Name: "add",
Flags: []cli.Flag{
&cli.StringFlag{
Name: "ref",
Usage: "Specific ref to use for this plugin",
},
},
Action: func(_ context.Context, cmd *cli.Command) error {
args := cmd.Args()
conf, err := config.LoadConfig()
Expand Down Expand Up @@ -710,15 +716,17 @@ func anyInstalled(conf config.Config, toolVersions []toolversions.ToolVersions)
return false
}

func pluginAddCommand(_ *cli.Command, conf config.Config, logger *log.Logger, pluginName, pluginRepo string) error {
func pluginAddCommand(cmd *cli.Command, conf config.Config, logger *log.Logger, pluginName, pluginRepo string) error {
if pluginName == "" {
// Invalid arguments
// Maybe one day switch this to show the generated help
// cli.ShowSubcommandHelp(cCtx)
return cli.Exit("usage: asdf plugin add <name> [<git-url>]", 1)
}

err := plugins.Add(conf, pluginName, pluginRepo, "")
ref := cmd.String("ref")

err := plugins.Add(conf, pluginName, pluginRepo, ref)
if err != nil {
logger.Printf("%s", err)

Expand Down
Loading