fix: add taskId validation and remove throwaway formatted[] array in createRoutine and updateRoutine#1505
Open
Abhishek2005-ard wants to merge 36 commits into
Conversation
…y required checks
…createRoutine and updateRoutine
Contributor
Author
|
close #1502 |
Contributor
Author
|
@aryandas2911 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in
backend/controllers/routineController.jsinside thecreateRoutineandupdateRoutinefunctions:taskIdformat validation — sending an invalidtaskIdcaused a Mongoosecast error caught only by the generic 500 handler with no useful message.
formatted[]array —endTimewas computed into a separate arrayused only for overlap detection and then discarded. The actual
itemssaved to DBnever had
endTime, creating inconsistent dead code.Root Cause
Bug 1 — Missing
taskIdValidation