fix: allow deletion of custom tag named 'Other' via toggleTag button#1465
Open
shabnam311 wants to merge 1 commit into
Open
fix: allow deletion of custom tag named 'Other' via toggleTag button#1465shabnam311 wants to merge 1 commit into
shabnam311 wants to merge 1 commit into
Conversation
Owner
|
resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1396
Problem
In
TaskFormModal.jsx, thetoggleTagfunction has a special case for the"Other"tag — it immediately returns after toggling the custom tag input, without ever checking whether"Other"is already present in the user's tags array.This means:
The tag becomes permanently stuck and can only be removed by clearing the entire form.
Fix
Added a check inside the
toggleTagfunction: if"Other"is already in thetagsarray, clicking the "Other" button now removes it from the array and hides the custom input. Only if "Other" is not in the tags array does clicking the button toggle the custom input visibility.Changes
frontend/src/components/Task/TaskFormModal.jsx— UpdatedtoggleTag()to checktags.includes("Other")before toggling the custom inputTesting