Skip to content

build: arm64 binaries #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

build: arm64 binaries #1518

wants to merge 4 commits into from

Conversation

raylu
Copy link

@raylu raylu commented Feb 28, 2025

Copy link
Owner

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I haven't had time to review much lately.

nit: Can you squash the commits together and change the commit message prefix from build: to ci:?

@@ -4,7 +4,7 @@ name: Build binaries for GitHub release

on:
release:
types: [created, edited, published]
types: [edited, published]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why did you remove created here? Don't we still want to build release binaries in that case (particularly to know before publishing the release if there's any issues)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the action is triggered twice for each release (see run 1 and 2 here https://github.com/raylu/git-branchless/actions/workflows/release.yml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arm builds
2 participants