Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sidekiq 8 #133

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Conversation

rus-max
Copy link
Contributor

@rus-max rus-max commented Mar 9, 2025

No description provided.

@rus-max rus-max changed the title add support for sidekiq 8 Add support for sidekiq 8 Mar 9, 2025
@andrcuns
Copy link
Collaborator

andrcuns commented Mar 9, 2025

@rus-max Could you also please add v8 to the test matrix in .github/workflows/test.yml?

@rus-max rus-max force-pushed the sidekiq-8-support branch from 80aea20 to 2d1dcde Compare March 10, 2025 04:09
@rus-max
Copy link
Contributor Author

rus-max commented Mar 10, 2025

@andrcuns Done

@andrcuns andrcuns self-requested a review March 10, 2025 06:35
@andrcuns
Copy link
Collaborator

It looks like we will have to resolve #129 first in order to be able to merge sidekiq version bump.

@rus-max rus-max force-pushed the sidekiq-8-support branch from 4c88a7d to ed3f315 Compare March 10, 2025 10:13
@rus-max rus-max force-pushed the sidekiq-8-support branch from ed3f315 to 0a7fa74 Compare March 10, 2025 10:20
@rus-max
Copy link
Contributor Author

rus-max commented Mar 10, 2025

I deleted the variable WITH_RACKUP
@andrcuns

@andrcuns andrcuns added enhancement New feature or request dependencies Pull requests that update a dependency file and removed enhancement New feature or request labels Mar 10, 2025
@andrcuns andrcuns merged commit e3e4c25 into arturictus:master Mar 10, 2025
8 of 9 checks passed
@andrcuns
Copy link
Collaborator

I deleted the variable WITH_RACKUP @andrcuns

@rus-max

Yeah. It's not ideal as we technically wanted to test with and without that gem being present, but I think it should be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants