release: v0.14.43 — an empty sidebar stops being silent - #1256
Merged
Conversation
A sidebar tab that is SELECTED while its content never paints used to look like nothing at all: an empty panel, with no way for the user to tell a broken extension from a frontend that dropped the tab from a page that simply had not finished rendering (#779). It now says so once, naming what was observed. The detector watches the DOCUMENT rather than the rail element. ComfyUI destroys and recreates that rail on focus-mode, linear-mode and builder-mode transitions — verified against the shipped frontends at 1.47.12, 1.48.7, 1.50.3 and 1.51.5, where it is `v-if`-gated rather than hidden, and where linear mode mounts a second separate instance. A subscription pinned to the first rail was therefore deaf after any of those transitions, which is exactly the silence it exists to break. The rail is now a gate and never a handle: its existence still proves the page has a sidebar we understand, and nothing more. An earlier revision also reported "our button is missing from the rail". That was removed rather than narrowed: upstream filters our tab out at render time on linear mode, so a HEALTHY panel would have tripped it, and no registry check can tell the two apart. Also retires the workflow and ask chat scopes, so a conversation is always panel-owned and a session can no longer be scoped to anything but the orchestrator (artokun/comfyui-mcp issue 884). Verified: 4444 tests green; the watchdog's own file grew 29 to 35. Four mutations applied and killed, including re-pinning the observer to the rail — the original defect — which kills three. Eight consecutive remounts against a starved panel still produce exactly one line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release cut carrying #779 (PR #804) and the chat-scope retirement (PR #680).
#779 — a selected sidebar tab whose content never paints now says so once, with what was observed. The detector watches the document, not the rail: ComfyUI destroys and recreates that rail on focus / linear / builder transitions (verified
v-if-gated on 1.47.12, 1.48.7, 1.50.3, 1.51.5; linear mode mounts a second instance), so a rail-pinned observer went deaf after any of them — the exact silence the watchdog exists to break. A pre-merge review caught that; the fix was re-reviewed and cleared.#680 — the conversation is always panel-owned; the workflow/ask chat scopes are retired, so a session cannot be scoped to anything but the orchestrator.
Suite green at 4444. The one failure in the full run was the known
manager-installwall-clock flake under load — 122/122 in isolation.🤖 Generated with Claude Code