Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: testifylint fix for encoded-compare #141

Merged
merged 1 commit into from
Nov 14, 2024
Merged

test: testifylint fix for encoded-compare #141

merged 1 commit into from
Nov 14, 2024
+1 −1

Conversation

gsporterfield
Copy link
Contributor

@gsporterfield gsporterfield commented Nov 13, 2024 •
edited
Loading

Applying testifylint recommendation to use JSONEq for encoded compare.

  Error: pkg/ohdear/site_test.go:63:4: encoded-compare: use assert.JSONEq (testifylint)
  			assert.Equal(
  			^

  Error: issues found

@gsporterfield
test: testifylint fix for encoded-compare
95eaffa 
testifylint recommendation to use JSONEq in encoded compare.
@gsporterfield gsporterfield marked this pull request as ready for review November 13, 2024 23:21
@gsporterfield gsporterfield requested a review from a team as a code owner November 13, 2024 23:21
@gsporterfield gsporterfield merged commit 8a32264 into main Nov 14, 2024
5 checks passed
@gsporterfield gsporterfield deleted the fix/testifylint-encoded-compare branch November 14, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloberg mloberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsporterfield @mloberg