fix: prevent double-close inflating zstd pool release counters#1
Merged
fix: prevent double-close inflating zstd pool release counters#1
Conversation
In writeZstd(), the zstdReader was closed twice: once by the buffer (which takes ownership via NewCASBufferFromReader) and again by defer zstdReader.Close(). Since metricsDecoder.Close() had no double-close guard — unlike the underlying pooledDecoder — each duplicate close incremented releases_total without a corresponding acquisition, causing releases to permanently exceed acquisitions. Remove the redundant defer and add double-close protection to both metricsEncoder and metricsDecoder as a safety net.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploying from buildbarn#330