Skip to content

Commit

Permalink
fixes following review
Browse files Browse the repository at this point in the history
  • Loading branch information
kooomix committed Nov 21, 2023
1 parent 005f3f2 commit 972e002
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ jobs:

- name: Get dependencies
run: go mod download

- name: Build
run: go build -v ./...

- name: Test
run: go test ./... -v --race
run: go test ./... -v --race -cover
2 changes: 1 addition & 1 deletion s3connector/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (s *s3ObjectStorage) GetObject(objPath S3ObjectPath) (io.ReadCloser, error)

if objPath.Range != nil {
if objPath.Range.Start < 0 || objPath.Range.End <= objPath.Range.Start {
return nil, fmt.Errorf("invalid range: start must be non-negative and end must be greater than start")
return nil, fmt.Errorf("invalid range: start must be non-negative and end must be greater than start, ranges are: %v", objPath.Range)
}
objRange = aws.String(fmt.Sprintf("bytes=%d-%d", objPath.Range.Start, objPath.Range.End))
}
Expand Down

0 comments on commit 972e002

Please sign in to comment.