Updated system_test_mapping.json with additional tests

[yonatanamz]

Type

Enhancement, Tests

---

Description

This PR includes several enhancements related to system tests:

• A new Python script, 'json_validator.py', was added to validate the JSON format of the 'system_test_mapping.json' file. This script is now used in the 'validate_json.yaml' workflow.
• The 'system_test_mapping.json' file was updated with additional target repositories for various tests, descriptions for some tests, and two new tests ('teams_alerts' and 'slack_alerts').

---

PR changes walkthrough

	Relevant files
Enhancement	1 files json_validator.py                                                                                      .github/workflows/scripts/json_validator.py A new Python script was added to validate the JSON format of the 'system_test_mapping.json' file. The script reads the JSON file and checks if it is correctly formatted. If there is a JSONDecodeError, it prints the error and exits with a status code of 1. +10/-0
Configuration changes	1 files validate_json.yaml                                                                                    .github/workflows/validate_json.yaml The inline Python code for JSON validation was replaced with a call to the newly added 'json_validator.py' script. This change makes the YAML file cleaner and the validation process more modular. +1/-9
Tests	1 files system_test_mapping.json                                                                        system_test_mapping.json **Several updates were made to the system tests mapping: Additional target repositories were added to various tests. Descriptions were added to some tests. Two new tests, 'teams_alerts' and 'slack_alerts', were added, including their target, target repositories, description, and skip_on_environment fields.** +48/-9

[codiumai-pr-agent-free]

PR Description updated to latest commit (9f248dd)

[codiumai-pr-agent-free]

PR Analysis

(review updated until commit 9f248dd)

• 🎯 Main theme: Enhancements and additions to system tests
• 📝 PR summary: This PR introduces a new Python script for validating the JSON format of the 'system_test_mapping.json' file and updates the 'system_test_mapping.json' file with additional target repositories for various tests, descriptions for some tests, and two new tests ('teams_alerts' and 'slack_alerts').
• 📌 Type of PR: Enhancement
• 🧪 Relevant tests added: Yes
• ⏱️ Estimated effort to review [1-5]: 2, because the changes are straightforward and involve mostly additions to a JSON file and a simple Python script for JSON validation.
• 🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR is well-structured and the changes are clear. The addition of the JSON validation script is a good practice to ensure the integrity of the JSON file. However, it would be beneficial to add more detailed descriptions for the tests in the 'system_test_mapping.json' file to provide more context about what each test is doing.

🤖 Code feedback:

---

relevant file	.github/workflows/scripts/json_validator.py
suggestion	Consider adding a more detailed error message that includes the line number where the JSON format error occurred. This will help in debugging if the JSON file becomes invalid. [medium]
relevant line	print(f'JSON format error in system_test_mapping.json: {e}')

---

relevant file	system_test_mapping.json
suggestion	For better organization and readability, consider grouping related tests together or categorizing them under different sections. [medium]
relevant line	"teams_alerts": {

---

✨ Usage tips:

---

To invoke the PR-Agent, add a comment using one of the following commands:

• /review: Request a review of your Pull Request.
• /describe: Update the PR title and description based on the contents of the PR.
• /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
• /ask <QUESTION>: Ask a question about the PR.
• /update_changelog: Update the changelog based on the PR's contents.
• /add_docs 💎: Generate docstring for new components introduced in the PR.
• /generate_labels 💎: Generate labels for the PR based on the PR's contents.
• /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

[github-actions]

Persistent review updated to latest commit 9f248dd

[refaelm92]

should be slack

[refaelm92]

should be teams