Merge pull request #426 from armosec/cloudjira

rename cloud account GUID attribute and update validation error messages
armosec · Jan 6, 2025 · 296087b · 296087b
2 parents bf310d0 + 70f95b4
commit 296087b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/identifiers/designators.go b/identifiers/designators.go
@@ -161,7 +161,7 @@ const (
 
 // CSPM related attributes
 const (
-	AttributeCloudAccountGUID = "accountGUID"
+	AttributeCloudAccountGUID = "cloudAccountGUID"
 	AttributeCloudAccountID   = "accountID"
 	AttributeCloudAccountName = "accountName"
 	AttributeFramework        = "framework"

diff --git a/notifications/integrationref.go b/notifications/integrationref.go
@@ -205,8 +205,8 @@ func (e *EntityIdentifiers) Validate() error {
 			return fmt.Errorf("security risk id, category and name are required for %s", e.Type)
 		}
 	case EntityTypeCloudResource:
-		if e.Name == "" || e.ResourceHash == "" || e.ResourceID == "" || e.CloudAccountGUID == "" {
-			return fmt.Errorf("name, resource hash, resource id and cloud account guid are required for %s", e.Type)
+		if e.ResourceHash == "" || e.ResourceID == "" || e.CloudAccountGUID == "" {
+			return fmt.Errorf("resource hash, resource id and cloud account guid are required for %s", e.Type)
 		}
 	case EntityTypeCloudRule:
 		if e.RuleHash == "" || e.CloudControlHash == "" || e.Severity == "" {
@@ -290,11 +290,11 @@ func (e *EntityIdentifiers) ToMap() map[string]string {
 	}
 
 	if e.RuleHash != "" {
-		entityMap["ruleHash"] = e.RuleHash
+		entityMap[identifiers.AttributeCloudRuleHash] = e.RuleHash
 	}
 
 	if e.CloudAccountGUID != "" {
-		entityMap["cloudAccountGUID"] = e.CloudAccountGUID
+		entityMap[identifiers.AttributeCloudAccountGUID] = e.CloudAccountGUID
 	}
 
 	return entityMap