feat(canary): add prometheus component #151
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogonthehorizon
force-pushed
the
feat/add-prometheus-canary-component
branch
4 times, most recently
from
bdc1dd0 to
498214c
Compare
dogonthehorizon
force-pushed
the
feat/add-prometheus-canary-component
branch
from
498214c to
5d10aa7
Compare
dogonthehorizon
force-pushed
the
feat/add-prometheus-canary-component
branch
2 times, most recently
from
e6d3753 to
012a03c
Compare
dogonthehorizon
force-pushed
the
feat/add-prometheus-canary-component
branch
2 times, most recently
from
3a92e0f to
38cf58c
Compare
Unfortunately Components don't compose as well as I'd like so we're unable to have features/canary and features/operations inheirt from the same Prometheus component. Hoping that some of this can be "linted" with conftest and at least point to potential issues w/ configuration
dogonthehorizon
force-pushed
the
feat/add-prometheus-canary-component
branch
from
38cf58c to
86d081a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.