Skip to content

Commit

Permalink
Fix debugger visualization of TArray<> and THashMap<>.
Browse files Browse the repository at this point in the history
These classes were renamed recently.

Change-Id: I90f9988e55e477f62a652bc6cc4c5a46254b52d7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667303
Reviewed-by: Herb Derby <[email protected]>
Commit-Queue: Herb Derby <[email protected]>
Commit-Queue: John Stiles <[email protected]>
Auto-Submit: John Stiles <[email protected]>
  • Loading branch information
johnstiles-google committed Apr 7, 2023
1 parent 5e936d5 commit c7c9cf8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions platform_tools/debugging/lldb/skia.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,11 +211,11 @@ def __lldb_init_module(debugger, dict):
debugger.HandleCommand(
'type summary add --summary-string "fPtr = ${var.fPtr}" -x "^sk_sp<.+>$" -w skia')
debugger.HandleCommand(
'type synthetic add -l skia.SkTArray_SynthProvider -x "^SkS?TArray<.+>$" -w skia')
'type synthetic add -l skia.SkTArray_SynthProvider -x "^skia_private::S?TArray<.+>$" -w skia')
debugger.HandleCommand(
'type synthetic add -l skia.SkSpan_SynthProvider -x "^SkSpan<.+>$" -w skia')
debugger.HandleCommand(
'type summary add --summary-string "size=${svar%#}" -e -x "^SkS?TArray<.+>$" -w skia')
'type summary add --summary-string "size=${svar%#}" -e -x "^skia_private::S?TArray<.+>$" -w skia')
debugger.HandleCommand(
'type synthetic add -l skia.AutoTArray_SynthProvider -x "^skia_private::AutoS?TArray<.+>$" -w skia')
debugger.HandleCommand(
Expand Down
8 changes: 4 additions & 4 deletions platform_tools/debugging/vs/Skia.natvis
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@
</Expand>
</Type>

<!-- SkTArray -->
<Type Name="SkTArray&lt;*&gt;">
<!-- TArray -->
<Type Name="skia_private::TArray&lt;*&gt;">
<DisplayString>{{size = {fSize}}}</DisplayString>
<Expand>
<Item Name="[size]">fSize</Item>
Expand All @@ -119,8 +119,8 @@
</Expand>
</Type>

<!-- SkTHashMap -->
<Type Name="SkTHashMap&lt;*,*,*&gt;">
<!-- THashMap -->
<Type Name="skia_private::THashMap&lt;*,*,*&gt;">
<DisplayString>{{size = {fTable.fCount}}}</DisplayString>
<Expand>
<CustomListItems>
Expand Down

0 comments on commit c7c9cf8

Please sign in to comment.