Skip to content

Commit

Permalink
Set max mipmap level along with base.
Browse files Browse the repository at this point in the history
Helps with performance and incorrect miplevel sampling on some drivers.
From: https://skbug.com/14194

Bug: skia:13566
Change-Id: I2689e2664a74bd04c28cf0c3df11eb17e332d29a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/658079
Reviewed-by: Robert Phillips <[email protected]>
Commit-Queue: Jim Van Verth <[email protected]>
  • Loading branch information
jvanverth authored and SkCQ committed Mar 20, 2023
1 parent 517bd02 commit 7e7782c
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 27 deletions.
8 changes: 0 additions & 8 deletions infra/bots/gen_tasks_logic/dm_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,6 @@ func (b *taskBuilder) dmFlags(internalHardwareLabel string) {
skip("gltestthreading", "gm", ALL, "lcdoverlap")
skip("gltestthreading", "gm", ALL, "textbloblooper")
// All of these GMs are flaky, too:
skip("gltestthreading", "gm", ALL, "savelayer_with_backdrop")
skip("gltestthreading", "gm", ALL, "persp_shaders_bw")
skip("gltestthreading", "gm", ALL, "dftext_blob_persp")
skip("gltestthreading", "gm", ALL, "dftext")
skip("gltestthreading", "gm", ALL, "gpu_blur_utils")
Expand All @@ -284,16 +282,10 @@ func (b *taskBuilder) dmFlags(internalHardwareLabel string) {
skip("gltestthreading", "gm", ALL, "draw_image_set")

// Fail on Iris Xe.
skip("gltestthreading", "gm", ALL, "anisotropic_image_scale_mip")
skip("gltestthreading", "gm", ALL, "bleed_downscale")
skip("gltestthreading", "gm", ALL, "degeneratesegments")
skip("gltestthreading", "gm", ALL, "mipmap_srgb")
skip("gltestthreading", "gm", ALL, "mipmap")
skip("gltestthreading", "gm", ALL, "ovals")
skip("gltestthreading", "gm", ALL, "persp_images")
skip("gltestthreading", "gm", ALL, "persp_shaders_aa")
skip("gltestthreading", "gm", ALL, "rtif_distort")
skip("gltestthreading", "gm", ALL, "skbug_8664")
skip("gltestthreading", "gm", ALL, "teenystrokes")
skip("gltestthreading", "gm", ALL, "texel_subset_linear_mipmap_nearest_down")
skip("gltestthreading", "gm", ALL, "yuv420_odd_dim_repeat")
Expand Down
Loading

0 comments on commit 7e7782c

Please sign in to comment.