Skip to content

Commit

Permalink
Fetch and use ninja when building Skia Release Docker image
Browse files Browse the repository at this point in the history
ninja is no longer in the depot_tools repo

Change-Id: If4bcc46000c3b751ae813c2e9df63efa0f2e1c72
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/635498
Reviewed-by: Joe Gregorio <[email protected]>
  • Loading branch information
kjlubick committed Jan 30, 2023
1 parent 9b3a9f2 commit 613c1f5
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions docker/skia-release/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ RUN if [ ! -z "${PATCH_REF}" ] ; then cd /tmp/skia/skia \

RUN cd /tmp/skia/skia \
&& gclient sync \
&& ./bin/fetch-gn
&& ./bin/fetch-gn \
&& ./bin/fetch-ninja

# Write args.gn.
RUN mkdir -p /tmp/skia/skia/out/Static
Expand All @@ -57,7 +58,7 @@ extra_ldflags = [ \n\
RUN cd /tmp/skia/skia \
&& ./bin/gn gen out/Static \
&& git rev-parse HEAD > VERSION \
&& /tmp/depot_tools/ninja -C out/Static \
&& ./bin/ninja -C out/Static \
&& chown -R skia:skia . \
# obj is readable only by the skia user. It needs additional
# permissions to be accessible for CI (see https://review.skia.org/487217).
Expand Down

0 comments on commit 613c1f5

Please sign in to comment.