Skip to content

Commit

Permalink
Disable ClangTidy namespace comments for short blocks.
Browse files Browse the repository at this point in the history
Namespace comments don't assist readability for blocks that can easily
fit on a single screen.

Change-Id: I93cbebe8e51400dead794c9eb41cb1eaa86bf756
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312639
Auto-Submit: John Stiles <[email protected]>
Reviewed-by: Mike Klein <[email protected]>
Commit-Queue: John Stiles <[email protected]>
  • Loading branch information
johnstiles-google authored and Skia Commit-Bot committed Aug 24, 2020
1 parent bf23d56 commit 3215385
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,7 @@ Checks: >
readability-redundant-smartptr-get,
readability-static-accessed-through-instance
CheckOptions:
- key: llvm-namespace-comment.ShortNamespaceLines
value: 40
- key: llvm-namespace-comment.SpacesBeforeComments
value: 2
2 changes: 1 addition & 1 deletion gm/pathfill.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ struct PathDY {
SkPath path;
SkScalar dy;
};
} // namespace
}

typedef PathDY (*MakePathProc)();

Expand Down

0 comments on commit 3215385

Please sign in to comment.