Skip to content

Commit

Permalink
[skottie] Clean up deprecated ImageAsset API
Browse files Browse the repository at this point in the history
All clients have been updated.

Change-Id: I389e11fa59eca1ec72dcad48899f505a675dadcc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/679376
Auto-Submit: Florin Malita <[email protected]>
Reviewed-by: Jorge Betancourt <[email protected]>
Commit-Queue: Jorge Betancourt <[email protected]>
  • Loading branch information
fmalita authored and SkCQ committed Apr 25, 2023
1 parent a496513 commit 2a2d795
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
6 changes: 0 additions & 6 deletions modules/skottie/src/layers/FootageLayer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,11 @@ SkMatrix image_matrix(const ImageAsset::FrameData& frame_data, const SkISize& de
return SkMatrix::I();
}

#ifdef SKOTTIE_LEGACY_ASSET_FIT
const auto size_fit_matrix = SkMatrix::RectToRect(SkRect::Make(frame_data.image->bounds()),
SkRect::Make(dest_size),
frame_data.scaling);
#else
const auto size_fit_matrix = frame_data.scaling == ImageAsset::SizeFit::kNone
? SkMatrix::I()
: SkMatrix::RectToRect(SkRect::Make(frame_data.image->bounds()),
SkRect::Make(dest_size),
static_cast<SkMatrix::ScaleToFit>(frame_data.scaling));
#endif

return frame_data.matrix * size_fit_matrix;
}
Expand Down
4 changes: 0 additions & 4 deletions modules/skresources/include/SkResources.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,7 @@ class SK_API ImageAsset : public SkRefCnt {
// Additional image transform to be applied before AE scaling rules.
SkMatrix matrix = SkMatrix::I();
// Strategy for image size -> AE asset size scaling.
#ifdef SKOTTIE_LEGACY_ASSET_FIT
SkMatrix::ScaleToFit scaling = SkMatrix::kCenter_ScaleToFit;
#else
SizeFit scaling = SizeFit::kCenter;
#endif
};

/**
Expand Down
4 changes: 0 additions & 4 deletions modules/skresources/src/SkResources.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,7 @@ ImageAsset::FrameData ImageAsset::getFrameData(float t) {
this->getFrame(t),
SkSamplingOptions(SkFilterMode::kLinear, SkMipmapMode::kNearest),
SkMatrix::I(),
#ifdef SKOTTIE_LEGACY_ASSET_FIT
SkMatrix::kCenter_ScaleToFit,
#else
SizeFit::kCenter,
#endif
};
}

Expand Down

0 comments on commit 2a2d795

Please sign in to comment.