feat: support --target for template compatibility markers#86
Merged
tgonzalezorlandoarm merged 1 commit intomainfrom Mar 11, 2026
Merged
feat: support --target for template compatibility markers#86tgonzalezorlandoarm merged 1 commit intomainfrom
tgonzalezorlandoarm merged 1 commit intomainfrom
Conversation
tgonzalezorlandoarm
force-pushed
the
compatibility-by-target
branch
3 times, most recently
from
bc44728 to
7488ede
Compare
Use --target on topo templates to generate a target description on the fly and annotate compatibility markers without requiring --target-description. Keep --target-description behavior unchanged, make the flags mutually exclusive. Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
force-pushed
the
compatibility-by-target
branch
from
7488ede to
3b1e807
Compare
muchzill4
approved these changes
Mar 11, 2026
Contributor
muchzill4
left a comment
muchzill4
left a comment
There was a problem hiding this comment.
LGTM.
Perhaps for another PR:
I do wonder if we should have a:
retrieveTargetDescription(cmd *cobra.Command) (*target.HardwareDescription, error)
addTargetDescriptionFlag(cmd *cobra.Command) // adds `--target-description`
addTargetDescriptionFlags(cmd *cobra.Command) // or `addTargetFlags()` - this would add both `--target` and `--target-description`It'd essentially do the flow you're doing here, but be reusable for future commands.
Contributor
Author
I've created a draft PR for this so that I don't forget: #92 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use
--targeton topo templates to generate a target description on the fly and annotate compatibility markers without requiring--target-description.Keep --target-description behavior unchanged, make the flags mutually exclusive.