fix!: allow Literal IP addresses in topo setup-keys#189
Open
tgonzalezorlandoarm wants to merge 2 commits intomainfrom
Open
fix!: allow Literal IP addresses in topo setup-keys#189tgonzalezorlandoarm wants to merge 2 commits intomainfrom
tgonzalezorlandoarm wants to merge 2 commits intomainfrom
Conversation
muchzill4
reviewed
Apr 8, 2026
tgonzalezorlandoarm
force-pushed
the
fix-setup-keys-for-unknown-hosts
branch
from
37f575c to
017355e
Compare
Contributor
Author
|
The following comment is for a different PR, but what I'm thinking about now is the edge case in which you have a Host configured in an ssh config but then you reference it with the IP instead of the Host name. |
Commit introduced a regression where topo setup-keys --target <ip> is not a valid target anymore. * Allow for literal IP addresses to be introduced. * Unify the key file naming convention under `id_<keytype>_topo_<user>_<alias/ip>` . Signed-off-by: Tomás González <[email protected]>
Specifying the User in the topo_config when adding a new config entry allows for better detection of conflicting users: `topo setup-keys --target <ip>` will generate SSH key files for the default user. We are already demanding a per-user alias. Might as well enforce it. Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
force-pushed
the
fix-setup-keys-for-unknown-hosts
branch
from
017355e to
9537383
Compare
tgonzalezorlandoarm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 7bd3a2b introduced a regression where
topo setup-keys --target <ip>is not a valid target anymore:raw IPs should be accepted.
Changes
id_<keytype>_topo_<user>_<alias/ip>.Userdirective in the config entry now that we are enforcing a per-user alias/config entry.