Skip to content

ci: use pull_request for security#67

Merged
yejseo01 merged 2 commits intomainfrom
pr-check-uses-pull_request
Apr 9, 2026
Merged

ci: use pull_request for security#67
yejseo01 merged 2 commits intomainfrom
pr-check-uses-pull_request

Conversation

@yejseo01
Copy link
Copy Markdown
Contributor

@yejseo01 yejseo01 commented Apr 7, 2026

@awphi pointed out using pull_request_target can cause some security complications so changing it.

Changes

  • use pull_request rather than pull_request_target

Checklist

  • 🤖 This change is covered by tests as required.
  • 🤹 All required manual testing has been performed.
  • 📖 All documentation updates are complete.

@yejseo01 yejseo01 requested a review from a team as a code owner April 7, 2026 10:40
Copy link
Copy Markdown

@awphi awphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@federicobozzini federicobozzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yejseo01 I think the commit category is wrong here. This is not a fix, it should be CI or a CI fix.

@Luke-Parkin Luke-Parkin changed the title fix: use pull_request for security ci: use pull_request for security Apr 7, 2026
@yejseo01 yejseo01 merged commit c3ea3fb into main Apr 9, 2026
9 of 14 checks passed
@yejseo01 yejseo01 deleted the pr-check-uses-pull_request branch April 9, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants