-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sparsepoly duplicate terms #954
Open
woojucy
wants to merge
12
commits into
arkworks-rs:master
Choose a base branch
from
woojucy:fix_sparsepoly_duplicate_terms
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix sparsepoly duplicate terms #954
woojucy
wants to merge
12
commits into
arkworks-rs:master
from
woojucy:fix_sparsepoly_duplicate_terms
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Zitek-Estrada <[email protected]>
Co-authored-by: Andrew Zitek-Estrada <[email protected]>
Co-authored-by: Andrew Zitek-Estrada <[email protected]>
Co-authored-by: Andrew Zitek-Estrada <[email protected]>
Co-authored-by: Andrew Zitek-Estrada <[email protected]>
Co-authored-by: Andrew Zitek-Estrada <[email protected]>
This got automatically closed when it was based on a branch that was merged and deleted: #915 (comment) |
@woojucy you need to the merge conflicts otherwise looks good to me |
Merge conflicts resolved! Let me know if anything else needs fixing. |
z-tech
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reintroduces the changes from the previously closed PR (#915) to address the issue where duplicate terms with the same degree were not explicitly handled in
univariate::SparsePolynomial::from_coefficients_vec
. In the current implementation, multiple terms with the same degree remain as separate entries, leading to inconsistencies in polynomial operations and unnecessary redundancy.To resolve this, an
is_valid_coefficients_vec
function has been introduced to pre-validate the input vector before constructing a sparse polynomial. This ensures that duplicate terms are merged, preventing redundancy.Changes Introduced
is_valid_coefficients_vec
to check for duplicate terms.from_coefficients_vec
only processes pre-validated input.rand_sparse_poly
behavior:rand_sparse_poly
and implement a retry mechanism.is_valid_coefficients_vec
and modify related test cases accordingly.Notes
rand_sparse_poly
should handle invalid input.