Add tom 256 #941
Closed
Add tom 256 #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
z-tech
reviewed
Feb 26, 2025
z-tech
reviewed
Feb 26, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: lovesh <[email protected]>
|
Wrt I squashed the commits and removed devbox. I also rebased on your PR. |
ineiti
changed the base branch from
master
to
z-tech/fix-werror-on-must-use-annotation
Pratyush
deleted the branch
arkworks-rs:z-tech/fix-werror-on-must-use-annotation
|
@Pratyush why did you close this PR? I made it depend on the |
|
Hm I didn't close it. I think GitHub automatically closes PRs which don't have a base. Could you rebase to master? Thank you, and sorry for the trouble! |
Pratyush
reviewed
Mar 4, 2025
| use ark_secp256k1::{fq::Fq, fr::Fr, Projective as G}; | ||
|
|
||
| bench!( | ||
| Name = "Secp256k1", |
There was a problem hiding this comment.
I think this is a copy-paste error?
Comment on lines
+4
to
+5
| /// A group element in the secp256k1 curve. | ||
| pub type GVar = ProjectiveVar<Config, FqVar>; |
| @@ -0,0 +1,7 @@ | |||
| //! This module implements the R1CS equivalent of `ark_secp256k1`. | |||
Comment on lines
+6
to
+7
| // #[small_subgroup_base = "3"] | ||
| // #[small_subgroup_power = "1"] |
There was a problem hiding this comment.
Suggested change
| // #[small_subgroup_base = "3"] | |
| // #[small_subgroup_power = "1"] |
Comment on lines
+6
to
+7
| // #[small_subgroup_base = "3"] | ||
| // #[small_subgroup_power = "1"] |
There was a problem hiding this comment.
Suggested change
| // #[small_subgroup_base = "3"] | |
| // #[small_subgroup_power = "1"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the Tom-256 curve from https://eprint.iacr.org/2021/1183 and described in https://neuromancer.sk/std/other/Tom-256
closes: #923
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer